[U-Boot] [PATCH 1/3] USB: Armada100: Add UTMI PHY interface driver

Prafulla Wadaskar prafulla at marvell.com
Thu Jan 26 18:59:11 CET 2012



> -----Original Message-----
> From: Ajay Bhargav [mailto:ajay.bhargav at einfochips.com]
> Sent: 25 January 2012 17:50
> To: linux at bohmer.net
> Cc: Prafulla Wadaskar; marek.vasut at gmail.com; u-boot at lists.denx.de;
> Ajay Bhargav
> Subject: [PATCH 1/3] USB: Armada100: Add UTMI PHY interface driver
> 
> This patch adds USB host controller's UTMI PHY interface driver for
> Armada100 SOCs.
> 
> Signed-off-by: Ajay Bhargav <ajay.bhargav at einfochips.com>
> ---
>  arch/arm/include/asm/arch-armada100/armada100.h |    7 ++
>  drivers/usb/host/utmi-armada100.c               |   87
> +++++++++++++++++++++++
>  drivers/usb/host/utmi-armada100.h               |   79
> ++++++++++++++++++++
>  3 files changed, 173 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/usb/host/utmi-armada100.c
>  create mode 100644 drivers/usb/host/utmi-armada100.h
> 
> diff --git a/arch/arm/include/asm/arch-armada100/armada100.h
> b/arch/arm/include/asm/arch-armada100/armada100.h
> index 0ed3a8e..d6984dc 100644
> --- a/arch/arm/include/asm/arch-armada100/armada100.h
> +++ b/arch/arm/include/asm/arch-armada100/armada100.h
> @@ -43,6 +43,13 @@
>  #define SSP2_APBCLK		0x01
>  #define SSP2_FNCLK		0x02
> 
> +/* USB Clock/reset control bits */
> +#define USB_SPH_AXICLK_EN	0x10
> +#define USB_SPH_AXI_RST		0x02
> +
> +/* MPMU Clocks */
> +#define MPMU_EN_ALL_CLKS	0x1EFFFF

Turning on all clocks is not logical to enable this support, only relevant clock necessary for this components SHOULD BE enabled.

Enabling clocks for unused peripherals/components may result in unnecessarily extra power consumption

Otherwise ack for rest of the patch

Regards..
Prafulla . . .


More information about the U-Boot mailing list