[U-Boot] [PATCH v2] ext2fs: fix warning: 'blocknxt' may be used uninitialized

Tom Rini trini at ti.com
Mon Jul 23 20:56:00 CEST 2012


On Sun, Jul 08, 2012 at 10:55:16PM +0200, Wolfgang Denk wrote:
> Dear Kim Phillips,
> 
> In message <20120703174156.a1082309c2b205216606a004 at freescale.com> you wrote:
> > This warning was introduced in 436da3c "ext2load: increase read
> > speed":
> > 
> > ext2fs.c: In function 'ext2fs_read_file':
> > ext2fs.c:458:19: warning: 'blocknxt' may be used uninitialized in this func=
> > tion [-Wuninitialized]
> > 
> > this change makes it go away.
> > 
> > Cc: Eric Nelson <eric.nelson at boundarydevices.com>
> > Cc: Thierry Reding <thierry.reding at avionic-design.de>
> > Cc: Jason Cooper <u-boot at lakedaemon.net>
> > Cc: Andreas Bie=DFmann <andreas.devel at googlemail.com>
> > Cc: Reinhard Arlt <reinhard.arlt at esd-electronics.com>
> > Signed-off-by: Kim Phillips <kim.phillips at freescale.com>
> > ---
> > v2: changed to Thierry's recommendation in:
> > 
> > http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/134043
> > 
> > build-tested only - please ack
> > 
> >  fs/ext2/ext2fs.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Applied, thanks.

This doesn't fix the warning for ELDK 4.2 toolchains (gcc 4.2.2):
ext2fs.c: In function 'ext2fs_read_file':
ext2fs.c:443: warning: 'blocknxt' may be used uninitialized in this
function

-- 
Tom


More information about the U-Boot mailing list