[U-Boot] [PATCH] mmc: tegra: fix boards that used old CONFIG_TEGRA2_MMC build switch

Tom Warren TWarren at nvidia.com
Fri Jun 1 20:09:35 CEST 2012


Stephen,

> -----Original Message-----
> From: Stephen Warren [mailto:swarren at wwwdotorg.org]
> Sent: Friday, June 01, 2012 10:49 AM
> To: Tom Warren
> Cc: u-boot at lists.denx.de; Tom Warren
> Subject: Re: [U-Boot] [PATCH] mmc: tegra: fix boards that used old
> CONFIG_TEGRA2_MMC build switch
> 
> On 06/01/2012 11:11 AM, Tom Warren wrote:
> > Some boards came in after my tegra2_mmc.* -> tegra_mmc.* change, and
> > didn't change CONFIG_TEGRA2_MMC to CONFIG_TEGRA_MMC.
> >
> > Signed-off-by: Tom Warren <twarren at nvidia.com>
> 
> There is also a fixup for CONFIG_TEGRA2_SPI below as well as for MMC;
> perhaps that should be mentioned in the commit description if not subject.

Yeah, sorry. That crept in. I'll add it to the commit msg.
> 
> It's not quite accurate to say that the boards came in after the rename;
> many of the instances below were things that got applied before the rename
> in git history and should really have been part of the rename patch, even if
> the patches were possibly posted to the mailing list after the rename patch
> was posted, but before being applied.

True. I'll reword the commit msg.
> 
> Grep'ing for the symbols that got renamed in the current u-boot-tegra/next
> still shows a lot of hits. For MMC those are all include guards so it
> probably doesn't cause bugs. For SPI, there are some #defines in the driver
> that didn't get converted.. Should those fixes be included in this patch
> too?
Current (as of right now) u-boot-tegra/next (which is where this patch lives) doesn't have any instances of CONFIG_TEGRA2_MMC nor CONFIG_TEGRA2_SPI that I can find. Were you using an older /next?  All T20 boards build fine from /next w/MAKEALL -s tegra2. I can't test MMC on the Tamonten/Paz00/etc. boards since I don't have any, but I believe I've fixed all the TEGRA2_MMC instances so they should work fine.

Tom

-- 
nvpublic


More information about the U-Boot mailing list