[U-Boot] [PATCH v2 09/10] tegra20: Remove CPU init code from tegra20 u-boot

Stephen Warren swarren at wwwdotorg.org
Wed Jun 6 18:51:09 CEST 2012


On 06/05/2012 03:20 PM, Allen Martin wrote:
> This code is now included in the tegra20 SPL

> @@ -323,34 +91,10 @@ void init_pmc_scratch(void)
>  
>  	/* ODMDATA is for kernel use to determine RAM size, LP config, etc. */
>  	writel(CONFIG_SYS_BOARD_ODMDATA, &pmc->pmc_scratch20);
> -
> -#ifdef CONFIG_TEGRA2_LP0
> -	/* save Sdram params to PMC 2, 4, and 24 for WB0 */
> -	warmboot_save_sdram_params();
> -#endif
>  }

Is that change intended, or was it a rebase mistake?

> diff --git a/arch/arm/cpu/tegra20-common/board.c b/arch/arm/cpu/tegra20-common/board.c

> @@ -69,6 +68,11 @@ int dram_init(void)
>  {
>  	/* We do not initialise DRAM here. We just query the size */
>  	gd->ram_size = query_sdram_size();
> +
> +#ifdef CONFIG_TEGRA2_LP0
> +	/* save Sdram params to PMC 2, 4, and 24 for WB0 */
> +	warmboot_save_sdram_params();
> +#endif

Hmmm. That's more than just removing the code that's now in the AVP
directory. Separate patch? The patch description also doesn't say why
this change is necessary.


More information about the U-Boot mailing list