[U-Boot] [PATCH 1/3] common/cmd_rsmode.c: add imx reset mode command

Eric Nelson eric.nelson at boundarydevices.com
Fri Jun 22 18:04:27 CEST 2012


On 06/21/2012 03:57 PM, Wolfgang Denk wrote:
> Dear Eric Nelson,
>
> In message<4FCD17A5.6030705 at boundarydevices.com>  you wrote:
>>
>>> The function of the watchdog should be reserved for auch systems who
>>> need it to implement security related functions; messing with it in
>>> unrelated places (like setting it into unexpected states and or
>>> timeouts) may cause undefined behaviour on such systems.
>>>
>>> Don't do it.
>>>
>>
>> My comment is that reset_cpu() should probably not return, and
>> at the moment it will. The minimum WDT timeout value is 1/2 second, so
>> execution will continue for some time less than that.
>>
>> It seems to me that this might be a bad thing, allowing unexpected
>> execution of commands in a script after the execution of the 'reset'
>> command.
>>
>> If I understand your comment, you're saying that reset_cpu() should
>> not be implemented using the watchdog.
>>
>> Is that right?
>
> No, that was not my intention.  I must have missed the fact that you
> were talking about reset_cpu() and only this function.  Please ignore
> me.
>

NP. I'll submit a patch to address the fact that the reset returns.


More information about the U-Boot mailing list