[U-Boot] [PATCH 1/7] net/designware: Fix to restore hw mac address

Amit Virdi amit.virdi at st.com
Fri Mar 2 12:27:40 CET 2012



On 3/1/2012 12:39 AM, Mike Frysinger wrote:
> On Wednesday 29 February 2012 05:37:20 Amit Virdi wrote:
>> The network controller mac resets hardware address stored in MAC_HI and
>> MAC_LO registers if mac is resetted. So, hw mac address needs to be
>> restored in case mac is explicitly resetted from driver.
>
> OK, but ...
>
>> --- a/drivers/net/designware.c
>> +++ b/drivers/net/designware.c
>>
>> +	dw_write_hwaddr(dev);
>
> ... please add a comment above this line explaining why you must explicitly
> make this call

Ok, Mike. I'll send V2 with comment added.

Thanks
Amit Virdi


More information about the U-Boot mailing list