[U-Boot] [PATCH 1/2] GPIO: Extend the cmd_gpio API by gpio_{from, to}_string()

Marek Vasut marex at denx.de
Mon May 14 13:31:35 CEST 2012


Dear Mike Frysinger,

> On Tuesday 01 May 2012 16:50:14 Marek Vasut wrote:
> > The gpio_from_string() call shall parse the incoming GPIO name taken
> > from the command line and return the GPIO number used within U-Boot or
> > return -1 on error.
> 
> i.e. the already existing name_to_gpio() func

You mean blackfin specific macro crap? Let's actually drop that and switch over 
to this one. That was my intention from start.

> > The gpio_to_string() on the other hand allows nicer reporting of GPIO
> > name in the output of cmd_gpio.
> 
> i don't see the value in this.  we already have the string name from the
> user, so all you've implemented is:
> 	gpio_to_string(gpio_from_string(argv[]))
> at which point, argv[] works fine.

This allows for taking multiple different inputs, while reporting one unified 
output.

> -mike

Best regards,
Marek Vasut


More information about the U-Boot mailing list