[U-Boot] [PATCH v4 25/27] arm/km: implement weak function board_spi_clam_bus/release

Prafulla Wadaskar prafulla at marvell.com
Fri May 25 12:36:44 CEST 2012



> -----Original Message-----
> From: Holger Brunck [mailto:holger.brunck at keymile.com]
> Sent: 24 May 2012 21:24
> To: Prafulla Wadaskar
> Cc: Valentin Longchamp; u-boot at lists.denx.de; Gerlando Falauto
> Subject: Re: [PATCH v4 25/27] arm/km: implement weak function
> board_spi_clam_bus/release
> 
> Hi Prafulla,
> 
> On 05/24/2012 10:46 AM, Prafulla Wadaskar wrote:
> >> -		kwmpp_config[2] = MPP2_NF_IO4;
> >> -		kwmpp_config[3] = MPP3_NF_IO5;
> >> -	}
> >> -
> >> -	/* Multi-Purpose Pins Functionality configuration */
> >> -	kirkwood_mpp_conf(kwmpp_config);
> >> -	kw_gpio_set_value(KM_FLASH_GPIO_PIN, gpio_value);
> >> +	kw_gpio_set_value(KM_FLASH_GPIO_PIN, 0);
> >>
> >>  	return 0;
> >>  }
> >>
> >> +void board_spi_release_bus(struct spi_slave *slave)
> >> +{
> >> +	kw_gpio_set_value(KM_FLASH_GPIO_PIN, 1);
> >> +}
> >> +
> >
> > Sorry, I didn't understand.
> > BTW: Why this is needed from SPI context?
> >
> > Please let's converge on SPI patches first and then send the rest of
> the dependent patch series, or exclude the SPI related changes for
> this patch series
> >
> > I will suggest to post smaller patch series targeting -
> > 1. bug fixes to the current supported boards, that will go fast in.
> > 2. SPI clam/release mpp patches
> > 3. New board supports
> >
> 
> the whole SPI stuff will be answered from Valentin when he is back
> next week.
> 
> What I could do to proceed with this patch series is to extract the
> bugfixes and
> small reworks which are preparations for the new boards in a single
> patch serie
> tomorrow that we can go ahead here.
> 
> This would be patches 01-09 from this serie. Ok?
> 

This sounds good, at least let's get in the bugfixes and updates.

Regards..
Prafulla . . .


More information about the U-Boot mailing list