[U-Boot] [PATCH] USB: add arrow key support to usb_kbd

Allen Martin amartin at nvidia.com
Wed Nov 7 00:06:39 CET 2012


On Tue, Nov 06, 2012 at 02:56:37PM -0800, Marek Vasut wrote:
> Dear Simon Glass,
> 
> > Hi Marek,
> > 
> > On Tue, Nov 6, 2012 at 2:49 PM, Marek Vasut <marex at denx.de> wrote:
> > > Dear Allen Martin,
> > > 
> > >> Check for scancodes for arrow keys and map them to ^F/^B, ^N/^P.
> > >> Control characters are used instead of ANSI sequence because the
> > >> queueing code in usb_kbd doesn't handle the data increase when one
> > >> keypress generates 3 keycodes.  The real fix is to convert this driver
> > >> to use the input subsystem and queue
> > > 
> > > If it's the real fix, then why not go for the real fix right away? :-(
> > 
> > Because it's a fair chunk of work
> 
> Let's either do it properly or not at all ... if I let you do these semi-
> complete fixes, we'll end up with a stinking pile of crap like windows ...
> 

I'm definately on board with changing it over to use input, it seems
like the right thing to do.  I just wasn't signing up to do the work
right now.  I'm happy to help review patches though if someone else
wants to jump in.

-Allen
-- 
nvpublic


More information about the U-Boot mailing list