[U-Boot] [PATCH] lsxl: set ncip to broadcast address

Wolfgang Denk wd at denx.de
Thu Oct 4 14:57:48 CEST 2012


Dear Prafulla Wadaskar,

In message <F766E4F80769BD478052FB6533FA745D235D228460 at SC-VEXCH4.marvell.com> you wrote:
> 
> > --- a/include/configs/lsxl.h
> > +++ b/include/configs/lsxl.h
> > @@ -146,7 +146,7 @@
> >  	"config_nc_dhcp=3Dsetenv autoload_old ${autoload}; "		\
> >  		"setenv autoload no "					\
> >  		"&& bootp "						\
> > -		"&& setenv ncip ${serverip} "				\
> > +		"&& setenv ncip 255.255.255.255 "			\
> 
> Michael
> Hard coding an ip-address is not recommended in u-boot environment.
> I would need ack from Joe and Wolfgang to pull this patch.

"not recommended" is an understatement.  "not permitted" is more
correct.

NAK.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Probably the best operating system in the world  is  the  [operating
system] made for the PDP-11 by Bell Laboratories."
                                           - Ted Nelson, October 1977


More information about the U-Boot mailing list