[U-Boot] [PATCH 3/7] usb: Update device class in usb device's descriptor

[Vivek Gautam]

Hi,


On Tue, Apr 2, 2013 at 3:39 PM, Marek Vasut <marex at denx.de> wrote:
> Dear Vivek Gautam,
>
>> CC: Amarendra
>>
>> On Thu, Mar 28, 2013 at 7:58 PM, Marek Vasut <marex at denx.de> wrote:
>> > Dear Vivek Gautam,
>> >
>> >> Fetch the device class into usb device's dwcriptors,
>> >> so that the host controller's driver can use this info
>> >> to differentiate between HUB and DEVICE.
>> >>
>> >> Signed-off-by: Amar <amarendra.xt at samsung.com>
>> >
>> > Is this a full name? Otherwise this patch is OK.
>> >
>> >> ---
>> >>
>> >>  common/usb.c |    5 +++++
>> >>  1 files changed, 5 insertions(+), 0 deletions(-)
>> >>
>> >> diff --git a/common/usb.c b/common/usb.c
>> >> index 40c1547..39fcedd 100644
>> >> --- a/common/usb.c
>> >> +++ b/common/usb.c
>> >> @@ -888,6 +888,11 @@ int usb_new_device(struct usb_device *dev)
>> >>
>> >>       dev->descriptor.bMaxPacketSize0 = desc->bMaxPacketSize0;
>> >>
>> >> +     /* Fetch the device class, driver can use this info
>> >> +      * to differentiate between HUB and DEVICE.
>> >> +      */
>> >> +     dev->descriptor.bDeviceClass = desc->bDeviceClass;
>> >> +
>
> btw this really needs fixing, both the comment and the dangling newline.

Sure, will fix this.

>
>> >>       /* find the port number we're at */
>> >>       if (parent) {
>> >>
>> >>               int j;
>> >



-- 
Thanks & Regards
Vivek