[U-Boot] [PATCH 13/14] i2c: zynq: Add support for Xilinx Zynq

[Tom Rini]

On Mon, Apr 22, 2013 at 04:52:11PM +0200, Michal Simek wrote:

> Support Xilinx Zynq i2c controller.
> 
> Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
> Signed-off-by: Michal Simek <michal.simek at xilinx.com>

Adding Heiko (http://patchwork.ozlabs.org/patch/238560/) ...

> ---
>  arch/arm/include/asm/arch-zynq/hardware.h |   2 +
>  drivers/i2c/Makefile                      |   1 +
>  drivers/i2c/zynq_i2c.c                    | 304 ++++++++++++++++++++++++++++++

There's 3 new checkpatch warnings here, please fix.  Also:

> --- a/arch/arm/include/asm/arch-zynq/hardware.h
> +++ b/arch/arm/include/asm/arch-zynq/hardware.h
> @@ -31,6 +31,8 @@
>  #define CONFIG_ZYNQ_GEM_BASEADDR1	0xE000C000
>  #define CONFIG_ZYNQ_SDHCI_BASEADDR0	0xE0100000
>  #define CONFIG_ZYNQ_SDHCI_BASEADDR1	0xE0101000
> +#define CONFIG_ZYNQ_I2C_BASEADDR0	0xE0004000
> +#define CONFIG_ZYNQ_I2C_BASEADDR1	0xE0005000

Same comment as before about CONFIG in <hardware.h>

> +/* Control register fields */
> +#define	ZYNQ_I2C_CONTROL_RW		0x00000001

'#define<space>', fix globally please.

> +	/* Temporarily disable restart (by clearing hold)... */
> +	/* It doesn't seem to work. */

/*
 * Multi line comments go like this
 */

[snip]
> +# define CONFIG_HARD_I2C		1

No need for training 1 here.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130422/7d0f9194/attachment.pgp>