[U-Boot] [PATCH] arm: mxs: Preprocess u-boot.bd so they contain full path

Marek Vasut marex at denx.de
Mon Apr 29 01:02:57 CEST 2013


Dear Otavio Salvador,

> On Sun, Apr 28, 2013 at 3:39 PM, Marek Vasut <marex at denx.de> wrote:
> > The u-boot-imx23.bd and u-boot-imx28.bd need to be preprocessed,
> > otherwise they have issues with out-of-tree build where elftosb tool
> > couldn't sometimes find the u-boot.bin and spl/u-boot-spl.bin .
> > 
> > Preprocess these .bd files with sed and insert full path to u-boot.bin
> > and spl/u-boot-spl.bin to prevent this issue. Moreover, to avoid adding
> > more churn into main Makefile, move all this preprocessing and u-boot.sb
> > generation into CPU directory instead.
> > 
> > Signed-off-by: Marek Vasut <marex at denx.de>
> > Cc: Fabio Estevam <fabio.estevam at freescale.com>
> > Cc: Stefano Babic <sbabic at denx.de>
> 
> Please Cc me in 'mxs' patches.
> 
> >  Makefile                                   |    7 ++-----
> >  arch/arm/cpu/arm926ejs/mxs/Makefile        |   10 ++++++++++
> >  arch/arm/cpu/arm926ejs/mxs/u-boot-imx23.bd |    4 ++--
> >  arch/arm/cpu/arm926ejs/mxs/u-boot-imx28.bd |    4 ++--
> 
> As you'll be processing this '.bd' files with sed, I think naming the
> u-boot.imx2[38].bd.in could make it easier to understand when someone
> not familiar with the code looks at it.

Not really, just keep them as they were.

> Just due curiosity how did you find it failed? I did try to build it
> with out-of-tree using MAKEALL and had no issues. Is it reproducable
> with higher number of parallel tasks?

Not sure anymore, I had this fix on my todo so I did it.

Best regards,
Marek Vasut


More information about the U-Boot mailing list