[U-Boot] [PATCH v2 2/4] arm:vf610:Enable the DSPI for Freescale vf610 platform

Chao Fu B44548 at freescale.com
Mon Dec 16 07:41:16 CET 2013


 
> WARNING: line over 80 characters
> #101: FILE: arch/arm/include/asm/arch-vf610/iomux-vf610.h:48:
> +       VF610_PAD_PTB19__DSPI0_CS0              = IOMUX_PAD(0x00a4,
> 0x00a4, 1, __NA_, 0,
> VF610_DSPI_PAD_CTRL),
> 
> WARNING: line over 80 characters
> #102: FILE: arch/arm/include/asm/arch-vf610/iomux-vf610.h:49:
> +       VF610_PAD_PTB20__DSPI0_SIN              = IOMUX_PAD(0x00a8,
> 0x00a8, 1, __NA_, 0,
> VF610_DSPI_SIN_PAD_CTRL),
> 
> WARNING: line over 80 characters
> #103: FILE: arch/arm/include/asm/arch-vf610/iomux-vf610.h:50:
> +       VF610_PAD_PTB21__DSPI0_SOUT             = IOMUX_PAD(0x00ac,
> 0x00ac, 1, __NA_, 0,
> VF610_DSPI_PAD_CTRL),
> 
> WARNING: line over 80 characters
> #104: FILE: arch/arm/include/asm/arch-vf610/iomux-vf610.h:51:
> +       VF610_PAD_PTB22__DSPI0_SCK              = IOMUX_PAD(0x00b0,
> 0x00b0, 1, __NA_, 0,
> VF610_DSPI_PAD_CTRL),
> 
> total: 0 errors, 4 warnings, 0 checks, 61 lines checked
> 
> 
> --
> Thanks,
> Jagan.
> 
> 

Dear Jagan,

Thank you! Our team hope this code about iomux definition orderliness and striking , we will keep the format , so the code every line in original file is over 80 characters. Do you think so?

       VF610_PAD_PTB15__I2C0_SDA               = IOMUX_PAD(0x0094, 0x0094, 2, 0x0340, 1, VF610_I2C_PAD_CTRL),
 +     VF610_PAD_PTB19__DSPI0_CS0              = IOMUX_PAD(0x00a4, 0x00a4, 1, __NA_, 0, VF610_DSPI_PAD_CTRL),
 +     VF610_PAD_PTB20__DSPI0_SIN              = IOMUX_PAD(0x00a8, 0x00a8, 1, __NA_, 0, VF610_DSPI_SIN_PAD_CTRL),
 +     VF610_PAD_PTB21__DSPI0_SOUT             = IOMUX_PAD(0x00ac, 0x00ac, 1, __NA_, 0, VF610_DSPI_PAD_CTRL),
 +     VF610_PAD_PTB22__DSPI0_SCK              = IOMUX_PAD(0x00b0, 0x00b0, 1, __NA_, 0, VF610_DSPI_PAD_CTRL),
       VF610_PAD_DDR_A15__DDR_A_15             = IOMUX_PAD(0x0220, 0x0220, 0, __NA_, 0, VF610_DDR_PAD_CTRL),
       VF610_PAD_DDR_A14__DDR_A_14             = IOMUX_PAD(0x0224, 0x0224, 0, __NA_, 0, VF610_DDR_PAD_CTRL),
       VF610_PAD_DDR_A13__DDR_A_13             = IOMUX_PAD(0x0228, 0x0228, 0, __NA_, 0, VF610_DDR_PAD_CTRL),

If we modify it . It looks as following:

      VF610_PAD_PTB15__I2C0_SDA
		= IOMUX_PAD(0x0094, 0x0094, 2, 0x0340, 1, VF610_I2C_PAD_CTRL),
      VF610_PAD_PTB19__DSPI0_CS0
		= IOMUX_PAD(0x00a4, 0x00a4, 1, __NA_, 0, VF610_DSPI_PAD_CTRL),
      VF610_PAD_PTB20__DSPI0_SIN
		= IOMUX_PAD(0x00a8, 0x00a8, 1, __NA_, 0, VF610_DSPI_SIN_PAD_CTRL),
      VF610_PAD_PTB21__DSPI0_SOUT
		= IOMUX_PAD(0x00ac, 0x00ac, 1, __NA_, 0, VF610_DSPI_PAD_CTRL),
      VF610_PAD_PTB22__DSPI0_SCK
		= IOMUX_PAD(0x00b0, 0x00b0, 1, __NA_, 0, VF610_DSPI_PAD_CTRL),
      VF610_PAD_DDR_A15__DDR_A_15
		= IOMUX_PAD(0x0220, 0x0220, 0, __NA_, 0, VF610_DDR_PAD_CTRL),
	...

Best Regards,
Fu Chao


More information about the U-Boot mailing list