[U-Boot] [PATCH 09/11] Blackfin: spi: add bf6xx spi driver

Sonic Zhang sonic.adi at gmail.com
Fri Feb 8 07:50:25 CET 2013


On Thu, Feb 7, 2013 at 6:23 PM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Sonic Zhang,
>
> In message <1360223258-6945-10-git-send-email-sonic.adi at gmail.com> you wrote:
>> From: Scott Jiang <scott.jiang.linux at gmail.com>
>>
>> Spi driver for bf60x is different from old one, so implement a new
>> driver for it.
>
> Checkpatch issues, please fix.
>
Could the checkpatch warning "line over 80 characters" in head file
Macro definition be ignored? I think put the explanation and the
definition on the same line is more clean than to chopping to 80.

#define SPI_CTL_FIFO0               0x00000000    /* FCWM: TFIFO empty
or RFIFO Full */
#define SPI_CTL_FIFO1               0x00010000    /* FCWM: TFIFO 75%
or more empty or RFIFO 75% or more full */
#define SPI_CTL_FIFO2               0x00020000    /* FCWM: TFIFO 50%
or more empty or RFIFO 50% or more full */


Regards,

Sonic


More information about the U-Boot mailing list