[U-Boot] [PATCH 03/10] am33xx: refactor am33xx clocks and add ti814x support

Matt Porter mporter at ti.com
Mon Feb 25 15:31:58 CET 2013


On Sun, Feb 17, 2013 at 09:17:01PM +0100, Peter Korsgaard wrote:
> >>>>> "Matt" == Matt Porter <mporter at ti.com> writes:
> 
>  Matt> Split clock.c for am335x and ti814x and add the ti814x include file.
>  Matt> Signed-off-by: Matt Porter <mporter at ti.com>
>  Matt> ---
>  Matt>  arch/arm/cpu/armv7/am33xx/Makefile               |    3 +-
>  Matt>  arch/arm/cpu/armv7/am33xx/clock-am335x.c         |  374 ++++++++++++++++++++++
>  Matt>  arch/arm/cpu/armv7/am33xx/clock-ti814x.c         |  234 ++++++++++++++
>  Matt>  arch/arm/cpu/armv7/am33xx/clock.c                |  374 ----------------------
>  Matt>  arch/arm/include/asm/arch-am33xx/clock.h         |    4 +
>  Matt>  arch/arm/include/asm/arch-am33xx/clocks_ti814x.h |  112 +++++++
>  Matt>  6 files changed, 726 insertions(+), 375 deletions(-)
>  Matt>  create mode 100644 arch/arm/cpu/armv7/am33xx/clock-am335x.c
>  Matt>  create mode 100644 arch/arm/cpu/armv7/am33xx/clock-ti814x.c
>  Matt>  delete mode 100644 arch/arm/cpu/armv7/am33xx/clock.c
>  Matt>  create mode 100644 arch/arm/include/asm/arch-am33xx/clocks_ti814x.h

Hi Peter...thanks for reviewing this.

> Do you have rename detection enabled? I would have imagined
> clock-am335x.c to show up as a copy of clock.c

On any given day I forget to format-patch with rename detection enabled.
You caught me...will be fixed in v2.

>  Matt> +++ b/arch/arm/cpu/armv7/am33xx/clock-am335x.c
>  Matt> @@ -0,0 +1,374 @@
>  Matt> +/*
>  Matt> + * clock.c
>  Matt> + *
>  Matt> + * clocks for AM33XX based boards
>  Matt> + *
>  Matt> + * Copyright (C) 2011, Texas Instruments, Incorporated - http://www.ti.com/
> 
> This is no longer clock.c or 2011. Care to update the header?

Ok

> 
>  Matt> +++ b/arch/arm/cpu/armv7/am33xx/clock-ti814x.c
>  Matt> @@ -0,0 +1,234 @@
>  Matt> +/*
>  Matt> + * clock.c
>  Matt> + *
>  Matt> + * clocks for TI814X based boards
>  Matt> + *
>  Matt> + * Copyright (C) 2011, Texas Instruments, Incorporated - http://www.ti.com/
> 
> Same here.

Ok

-Matt


More information about the U-Boot mailing list