[U-Boot] [PATCH V4] nitrogen: Use unsigned long to specify the total RAM size

Albert ARIBAUD albert.u.boot at aribaud.net
Thu Mar 14 14:15:02 CET 2013


Hi Stefano,

On Thu, 14 Mar 2013 09:09:21 +0100, Stefano Babic <sbabic at denx.de>
wrote:

> From: "fabio.estevam at freescale.com" <fabio.estevam at freescale.com>
> 
> When building for the nitrogen boards with 2GB the following warning happens:
> 
> nitrogen6x.c:89:38: warning: integer overflow in expression [-Woverflow]
> 
> 2GB can not fit in 32-bits, so use ulong instead.
> 
> Reported-by: Albert Aribaud <albert.u.boot at aribaud.net>
> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
> Signed-off-by: Stefano Babic <sbabic at denx.de>

This somehow is redundant with Fabio's patch 2/2 with the same summary,
right?

Stefano: once Fabio's series is OK,

- either you rollback your ToT, apply Fabio's series before it, and
  then send out an amended PR, which is more work but makes your tree
  build-clean;

- or I apply Fabio's series then your existing PR, which is less
  work but leaves your current ToT non-build-clean until you merge back
  from ARM (or mainline once I do my own PR).

What do you prefer? I would favor the first option, FWIW.

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list