[U-Boot] [RFC] Add 64-bit data support for memory commands

Albert ARIBAUD albert.u.boot at aribaud.net
Thu Feb 13 03:29:24 CET 2014


Hi York,

On Wed, 12 Feb 2014 14:42:30 -0800, York Sun <yorksun at freescale.com>
wrote:

> On 02/12/2014 02:11 PM, Wolfgang Denk wrote:
> > Dear York Sun,
> > 
> > In message <1392240023-25205-1-git-send-email-yorksun at freescale.com> you wrote:
> >> For aarch64, unsigned long is 64-bit data. Memory commands should be fixed
> >> with u32 for 32-bit address access. A double word data size is added to
> >> support 64-bit data.
> >>
> >> Signed-off-by: York Sun <yorksun at freescale.com>
> > 
> > Can you please make all this code conditional for 64 bit architectures
> > only, so that 32 bit systems do not suffer from the increased code
> > size?
> > 
> 
> I should point out the main reason of this patch is to fix the wrong size of
> ulong, used in many places of cmd_mem.c. I can leave out the support of 64-bit
> data. I don't see how useful it is.

Support for the architecture's native size seems sensible to me.

Mind you, I would personally be ok if it was put under its own option
(something like CONFIG_SYS_SUPPORT_64BIT_DATA) which would be active by
default for 64-bit arches and inactive for others, but would allow any
non-64-bit target to enable double-word values if they so want.

> York

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list