[U-Boot] [RFC] Add 64-bit data support for memory commands

York Sun yorksun at freescale.com
Thu Feb 13 03:57:03 CET 2014


On Feb 12, 2014, at 6:41 PM, FengHua wrote:

> 
> 
> 
>> -----Original Messages-----
>> From: "Wolfgang Denk" <wd at denx.de>
>> Sent Time: 2014-02-13 06:11:01 (Thursday)
>> To: "York Sun" <yorksun at freescale.com>
>> Cc: scottwood at freescale.com, u-boot at lists.denx.de
>> Subject: Re: [U-Boot] [RFC] Add 64-bit data support for memory commands
>> 
>> Dear York Sun,
>> 
>> In message <1392240023-25205-1-git-send-email-yorksun at freescale.com> you wrote:
>>> For aarch64, unsigned long is 64-bit data. Memory commands should be fixed
>>> with u32 for 32-bit address access. A double word data size is added to
>>> support 64-bit data.
>>> 
>>> Signed-off-by: York Sun <yorksun at freescale.com>
>> 
>> Can you please make all this code conditional for 64 bit architectures
>> only, so that 32 bit systems do not suffer from the increased code
>> size?
>> 
>> Thanks.
>> 
>> Best regards,
>> 
>> Wolfgang Denk
> How about use some macro from compiler of sizeof(long)? 
> Maybe this could avoid conditional switch, and cmd_mem work with 32 and 64 bit platform.
> 

I dropped the 64-bit support in v2 RFC patch, focusing on fixing things. We can add 64-bit data is needed. I don't see the need yet.

York



More information about the U-Boot mailing list