[U-Boot] [PATCH v3 1/2] initial support for pengwyn board

Wolfgang Denk wd at denx.de
Wed Jan 29 20:12:46 CET 2014


Dear Lothar Felten,

In message <1391009943-8028-2-git-send-email-lothar.felten at gmail.com> you wrote:
> Signed-off-by: Lothar Felten <lothar.felten at gmail.com>

You still fail to provide a comit message here.

The comments in the cover letter may be helpful, but they will not
show up in the git log, i. e. they are lost.  We need this information
here.


> ---

This is patch version 3, and even though I explicitly pointed you at
the documentation, you fail to tell us here (below this little "---"
line) what exactly has been changed since version 2.  We don;t have
time and resources to compare your patch versions ourself to fuind out
which of the review commetns you might have addressed, or not.

Sorry, but my review stops here with a NAK (see the other message).

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Programmer's Lament: (Shakespeare, Macbeth, Act I, Scene vii)
        "That we but teach bloody instructions,
        which, being taught, return to plague the inventor..."


More information about the U-Boot mailing list