[U-Boot] [PATCH] common: env_common: make env_get_char_spec __weak

Jeroen Hofstee jeroen at myspectrum.nl
Fri Jul 11 19:16:07 CEST 2014


Hello Wolfgang,

On 11-07-14 06:26, Wolfgang Denk wrote:
> Dear Jeroen,
>
> In message <1405027670-28516-1-git-send-email-jeroen at myspectrum.nl> you wrote:
>>   
>> -static uchar __env_get_char_spec(int index)
>> +__weak uchar env_get_char_spec(int index)
> __weak static ... ?

tempting huh, but it is the patch format with tricks
you in thinking that. The weak is actually added to
the function without the leading underscores, a
couple of lines below (which wasn't static and
shouldn't become so).

Regards,
Jeroen




More information about the U-Boot mailing list