[U-Boot] socfpga: initialize MMC

Wolfgang Denk wd at denx.de
Wed Jul 16 15:13:30 CEST 2014


Dear Pavel,

In message <20140716125238.CF3833804B5 at gemini.denx.de> I wrote:
> 
> > +	add_dwmci(host, host->bus_hz, host->bus_hz);
> 
> Is there a free(host) anywhere?

I think there is none, which raises the question why you use malloc()
in the first place.  Just use a struct on the stack.

Also, please make sure to check the return code of add_dwmci() for
errors, and handle these as needed.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The light at the end of the tunnel is usually a "No Exit" sign.


More information about the U-Boot mailing list