[U-Boot] [PATCH v3 05/10] sunxi: Add sun4i support

Siarhei Siamashka siarhei.siamashka at gmail.com
Wed Jul 23 19:53:43 CEST 2014


On Mon,  9 Jun 2014 11:36:57 +0200
Hans de Goede <hdegoede at redhat.com> wrote:

> Add support for the Allwinner A10 SoC also known as the Allwinner sun4i family,
> and add the Cubieboard board which uses the A10 SoC.
> 
> Compared to sun7 only the DRAM controller is a bit different:
> -Controller reset bits are inverted, but only for Rev. A
> -Different hpcr values
> -No MBUS on sun4i
> -Various other initialization changes
> 
> Signed-off-by: Henrik Nordstrom <henrik at henriknordstrom.net>
> Signed-off-by: Stefan Roese <sr at denx.de>
> Signed-off-by: Oliver Schinagl <oliver at schinagl.nl>
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> Acked-by: Ian Campbell <ijc at hellion.org.uk>
>
> ---
>  arch/arm/cpu/armv7/sunxi/Makefile   |  2 +
>  arch/arm/cpu/armv7/sunxi/cpu_info.c |  7 ++++
>  arch/arm/cpu/armv7/sunxi/dram.c     | 81 +++++++++++++++++++++++++++++++++++--
>  board/sunxi/Makefile                |  1 +
>  board/sunxi/dram_cubieboard.c       | 31 ++++++++++++++
>  boards.cfg                          |  1 +
>  include/configs/sun4i.h             | 23 +++++++++++
>  7 files changed, 143 insertions(+), 3 deletions(-)
>  create mode 100644 board/sunxi/dram_cubieboard.c
>  create mode 100644 include/configs/sun4i.h

This patch is piling up a lot of various loosely related changes.
Isn't the addition of Cubieboard to boards.cfg kind of orthogonal
to the sun4i SoC variant support? This makes cherry picking or
reverting the patch unnecessarily difficult.

-- 
Best regards,
Siarhei Siamashka


More information about the U-Boot mailing list