[U-Boot] [PATCH 01/12] sunxi: mksunxiboot: Fix loading of files with a size which is not a multiple of 4

Ian Campbell ijc at hellion.org.uk
Wed Jul 23 20:30:38 CEST 2014


On Wed, 2014-07-23 at 18:40 +0100, Ian Campbell wrote:
> On Wed, 2014-07-23 at 20:29 +0300, Siarhei Siamashka wrote:
> > On Fri, 30 May 2014 10:19:16 +0100
> > Ian Campbell <ijc at hellion.org.uk> wrote:
> > 
> > > On Fri, 2014-05-30 at 11:06 +0200, Hans de Goede wrote:
> > > > We should not be aligning the amount of bytes which we try to read from the
> > > > disk, this leads to trying to read more bytes then there are which fails.
> > > > 
> > > > file_size is already aligned to BLOCK_SIZE before being stored in
> > > > img.header.length, so there is no need for load_size at all.
> > > > 
> > > > Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> > > 
> > > Acked-by: Ian Campbell <ijc at hellion.org.uk>
> > 
> > Acked-by: Siarhei Siamashka <siarhei.siamashka at gmail.com>
> > 
> > Was there any valid reason why this important bugfix has not been
> > nominated for v2014.07?
> 
> Not sure what you mean, it is part of the PR at
> http://patchwork.ozlabs.org/patch/371704/

Oh, you said .07 which was the last one.

There was no particular reason, it just didn't make it. We were still
figuring out the upstream work flow at the time.

Ian.



More information about the U-Boot mailing list