[U-Boot] [PATCH 2/2] tools: include u-boot version of sha256.h

Jeroen Hofstee jeroen at myspectrum.nl
Tue Jun 3 20:27:42 CEST 2014


Hello Simon,

On di, 2014-06-03 at 08:11 -0600, Simon Glass wrote:
> On 30 May 2014 07:45, Jeroen Hofstee <jeroen at myspectrum.nl> wrote:
> > When building tools the u-boot specific sha256.h is required, but the
> > host version of sha256.h is used when present. This leads to build errors
> > on FreeBSD which does have a system sha256.h include. Like libfdt_env.h
> > explicitly include u-boot's sha256.h.
> >
> > cc: Simon Glass <sjg at chromium.org>
> > Signed-off-by: Jeroen Hofstee <jeroen at myspectrum.nl>
> 
> There might be a general approach here, but this is just as reasonable
> as the libfdt_env.h inclusion.
> 
> Acked-by: Simon Glass <sjg at chromium.org>
> 
> (tested with buildman - no build regressions on all boards)

Thanks for testing. One of the more generic solutions I considered is to
actually move all such headers to include/u-boot. I tried that, but it
rapidly becomes a big patch touching files in all archs, which is a bit
too big after an rc2 is already out.

Tom, since this does fix a build error, can you consider including this
in the next release? (and preferably "Makefile: fix clang warnings due
to clang support" as well, as it gains nothing but introduces quite some
compile noise [but is waiting for feedback from Masahiro]).

Regards,
Jeroen






More information about the U-Boot mailing list