[U-Boot] [U-Boot, v2, 5/9] fdt_support: refactor fdt_fixup_stdout() function

Tom Rini trini at ti.com
Thu Jun 19 17:20:38 CEST 2014


On Fri, Apr 18, 2014 at 05:41:01PM +0900, Masahiro Yamada wrote:

> - Do not use a deep indentation. We have only 80-character
>    on each line and 1 indentation consumes 8 spaces. Before the
>    code moves far to the right, you should consider to
>    fix your code. See Linux Documentation/CodingStyle.
> 
>  - Add CONFIG_OF_STDOUT_VIA_ALIAS and OF_STDOUT_PATH macros
>    only to their definition. Do not add them to both
>    callee and caller. This is a tip to avoid using #ifdef
>    everywhere.
> 
>  - OF_STDOUT_PATH and CONFIG_OF_STDOUT_VIA_ALIAS are exclusive.
>    If both are defined, the former takes precedence.
>    Do not try to fix-up "linux,stdout-path" property twice.
> 
> Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
> Acked-by: Simon Glass <sjg at chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140619/63e920eb/attachment.pgp>


More information about the U-Boot mailing list