[U-Boot] [PATCH v1 06/10] spl, nand, atmel_nand: add erase one block function

Scott Wood scottwood at freescale.com
Fri Oct 3 01:45:52 CEST 2014


On Thu, 2014-10-02 at 07:21 +0200, Heiko Schocher wrote:
> Hello Scott,
> 
> Am 02.10.2014 03:17, schrieb Scott Wood:
> > On Wed, 2014-10-01 at 07:54 +0200, Heiko Schocher wrote:
> >> diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
> >> index 8438490..ee2c3fe 100644
> >> --- a/include/linux/mtd/nand.h
> >> +++ b/include/linux/mtd/nand.h
> >> @@ -1020,5 +1020,6 @@ void nand_write_buf16(struct mtd_info *mtd, const uint8_t *buf, int len);
> >>   void nand_read_buf(struct mtd_info *mtd, uint8_t *buf, int len);
> >>   void nand_read_buf16(struct mtd_info *mtd, uint8_t *buf, int len);
> >>   uint8_t nand_read_byte(struct mtd_info *mtd);
> >> +int nand_erase_one(int block, int page);
> >
> > This doesn't belong under the heading "Standard NAND functions from
> > nand_base.c", and probably doesn't belong in this file.
> 
> Ah, ok. Where would be a correct place for it?

If you don't want to make it atmel-specific, put an "spl" in the name
and put it in include/nand.h.

-Scott




More information about the U-Boot mailing list