[U-Boot] [PATCH v3] imx6: add Bachmann OT1200 board

Christian Gmeiner christian.gmeiner at gmail.com
Mon Oct 6 09:29:22 CEST 2014


Hi

>
>> --- /dev/null
>> +++ b/board/bachmann/ot1200/Kconfig
>> @@ -0,0 +1,23 @@
>> +if TARGET_OT1200
>> +
>> +config SYS_CPU
>> +     string
>> +     default "armv7"
>> +
>> +config SYS_BOARD
>> +     string
>> +     default "ot1200"
>> +
>> +config SYS_VENDOR
>> +     string
>> +     default "bachmann"
>> +
>> +config SYS_SOC
>> +     string
>> +     default "mx6"
>> +
>> +config SYS_CONFIG_NAME
>> +     string
>> +     default "ot1200"
>> +
>
>
> The type "string" is not mandatory since
> commit 461be2f96e4b87e5065208c6659a47dd0ad9e9f8.
> You can save 5 lines.

Nice to know.

> Since it is not a big deal,
> I don't think you have to resend it just for fixing this.
> (I am just pointing out a minor thing I found by chance.)
>
> If you like or you have a chance to send v4 for another fix,
> I recommend you to drop "string".
>

I am not sure if the current patch set gets accepted or not. Either way
I will send a v4 or a followup patch to correct this. I have some more
patches in my queue but I need to wait until this patch hits u-boot-imx.

greets
--
Christian Gmeiner, MSc

https://soundcloud.com/christian-gmeiner


More information about the U-Boot mailing list