[U-Boot] Discussion topics / issues

Pavel Machek pavel at denx.de
Fri Oct 10 01:05:59 CEST 2014


On Fri 2014-10-10 00:24:46, Wolfgang Denk wrote:
> Dear Pavel,
> 
> In message <20141009221154.GA24774 at amd> you wrote:
> > 
> > Something like this could help..?
> > 									Pavel
> > 
> > --- /dev/null	2014-10-09 01:15:57.354292026 +0200
> > +++ doc/SubmittingPatches	2014-10-09 23:58:53.058883776 +0200
> 
> Is there anything wrong with [1] ?
> 
> [1] http://www.denx.de/wiki/U-Boot/Patches

..and actually... it makes submitting patches rather hard.

[PATCH] fix compilation on socfpga

> Please add tags to the subject

[PATCHv2] arm: socfpga: fix compilation on socfpga

> Please add diff from previous version

[PATCHv3] arm: socfpga: fix compilation on socfpga

---

v2: added tags to the subject

v3: added diffs to previous version

. (From memory, but IIRC something very similar to this happened before).

This scares of all but the most determined patch submitters, and does
not really improve code quality.

I'd argue that if only changelog is updated, it is _not_ a new version
of patch, and does not need changelog diff. Or maybe be less strict
policy / less strict enforcement of the policy in trivial cases.

Best regards,

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


More information about the U-Boot mailing list