[U-Boot] [PATCH 1/3] usb: dwc2: Add driver for Synopsis DWC2 USB IP block

Stephen Warren swarren at wwwdotorg.org
Wed Sep 24 05:31:26 CEST 2014


On 09/21/2014 07:13 AM, Marek Vasut wrote:
> From: Oleksandr Tymoshenko <gonzo at bluezbox.com>
> 
> This is the USB host controller used on the Altera SoCFPGA and Raspbery Pi.
> 
> This code has three checkpatch warnings, but to make sure it stays at least
> readable and clear, these are not fixed. These bugs are in the USB request
> handling combinatorial logic, so any abstracting of those is out of question.
> 
> Tested on DENX MCV (Altera SoCFPGA 5CSFXC6C6U23C8N) and RPi B+ (BCM2835).

Patches 1, 3,
Tested-by: Stephen Warren <swarren at nvidia.com>

That said, I needed "ARM: rpi_b: query internal MAC address from
firmware" to get the MAC address set up correctly. I obviously used that
when testing. I guess I should send that patch:-)

Patch 3,
Acked-by: Stephen Warren <swarren at nvidia.com>

> Signed-off-by: Oleksandr Tymoshenko <gonzo at bluezbox.com>
> Signed-off-by: Stephen Warren <swarren at wwwdotorg.org>

Given this patch has quite a few changes relative to what Oleksandr or I
sent, it might be nice to include some notes in the commit description
re: what you changed.

[Marek, fiddled with the frob ...]

> Signed-off-by: Marek Vasut <marex at denx.de>

>  README                    |   3 +
>  drivers/usb/host/Makefile |   3 +
>  drivers/usb/host/dwc2.c   | 952 ++++++++++++++++++++++++++++++++++++++++++++++
>  drivers/usb/host/dwc2.h   | 784 ++++++++++++++++++++++++++++++++++++++

In the version Oleksandr sent, there was some header that defined the HW
registers that had some problematic Synopsis license. Did dwc2.h come
from the Linux kernel? If that is the case, aren't we supposed to say
which kernel commit and path it came from?


More information about the U-Boot mailing list