[U-Boot] [PATCH 27/51] fpga: altera: Clean up the printing and debug

[Marek Vasut]

On Wednesday, September 24, 2014 at 02:46:17 PM, Michal Simek wrote:
> On 09/21/2014 03:11 PM, Marek Vasut wrote:
> > Clean up the printf() statements and get rid of the PRINTF()
> > macro by replacing it with debug_cond().
> > 
> > Signed-off-by: Marek Vasut <marex at denx.de>
> > Cc: Chin Liang See <clsee at altera.com>
> > Cc: Dinh Nguyen <dinguyen at altera.com>
> > Cc: Albert Aribaud <albert.u.boot at aribaud.net>
> > Cc: Tom Rini <trini at ti.com>
> > Cc: Wolfgang Denk <wd at denx.de>
> > Cc: Pavel Machek <pavel at denx.de>

[...]

> 
> WARNING: space prohibited between function name and open parenthesis '('
> #113: FILE: drivers/fpga/altera.c:29:
> +	if (!altera_validate (desc, (char *)__func__)) {
> 
> WARNING: space prohibited between function name and open parenthesis '('
> #165: FILE: drivers/fpga/altera.c:72:
> +	if (!altera_validate (desc, (char *)__func__)) {
> 
> WARNING: space prohibited between function name and open parenthesis '('
> #209: FILE: drivers/fpga/altera.c:109:
> +	if (altera_validate (desc, (char *)__func__)) {
> 
> WARNING: line over 80 characters
> #275: FILE: drivers/fpga/altera.c:160:
> +			printf("Device Function Table @ 0x%p\n", desc-
>iface_fns);
> 
> CHECK: Alignment should match open parenthesis
> #290: FILE: drivers/fpga/altera.c:171:
> +				printf("%s: No support for ACEX1K devices.\n",
> +						__func__);
> 
> WARNING: line over 80 characters
> #330: FILE: drivers/fpga/altera.c:217:
> +			printf("%s: Invalid family type, %d\n", fn, desc-
>family);

The patch does not address this issue, this is addressed by one of the patches 
further down the pipe (but it is addressed). I tried to keep these patches 
somewhat separated to keep the changes reasonably contained, but the file was a 
mess. The best suggestion I can give you is to use checkpatch -f on the 
resulting altera.c file ; there are still a few warnings, but it's much better 
than it was.

Best regards,
Marek Vasut