[U-Boot] [patch] socfpga: move configuration options to config file

[Pavel Machek]

On Mon 2015-04-20 21:23:23, Marek Vasut wrote:
> On Monday, April 20, 2015 at 02:30:48 PM, Pavel Machek wrote:
> > Setting configuration options in header file leads to incosistency
> > between .config user sees, and .config he has. What is worse, a lot of
> > compile warnings is presented for any such config option user sets in
> > .config.
> 
> Can you please elaborate on such warnings ?

Lets remove CONFIG_CMD_RUN from .config, then select it:

run (CMD_RUN) [N/y/?] (NEW) y

Now you warning for most C files:

  CC      arch/arm/lib/asm-offsets.s
  In file included from include/configs/socfpga_cyclone5.h:16:0,
                   from include/config.h:5,
		                    from include/common.h:18,
				                     from
  arch/arm/lib/asm-offsets.c:15:
  include/config_cmd_default.h:38:0: warning: "CONFIG_CMD_RUN"
  redefined [enabled by default]
   #define CONFIG_CMD_RUN  /* run command in env variable */
    ^
    In file included from ././include/linux/kconfig.h:4:0,
                     from <command-line>:0:
		     include/generated/autoconf.h:35:0: note: this is
  the location of the previous definition
   #define CONFIG_CMD_RUN 1
    ^
    In file included from include/configs/socfpga_cyclone5.h:16:0,
                     from include/config.h:5,
		                      from include/common.h:18,
				                       from
  lib/asm-offsets.c:15:
  include/config_cmd_default.h:38:0: warning: "CONFIG_CMD_RUN"
  redefined [enabled by default]
   #define CONFIG_CMD_RUN  /* run command in env variable */
    ^
    In file included from ././include/linux/kconfig.h:4:0,
                     from <command-line>:0:
		     include/generated/autoconf.h:35:0: note: this is
  the location of the previous definition
   #define CONFIG_CMD_RUN 1
    ^
      CHK     include/generated/asm-offsets.h
        CHK     include/generated/generic-asm-offsets.h
	  LDS     u-boot.lds
	  In file included from
  include/configs/socfpga_cyclone5.h:16:0,
                   from include/config.h:5,
		                    from arch/arm/cpu/u-boot.lds:10:
				    include/config_cmd_default.h:38:0:
  warning: "CONFIG_CMD_RUN" redefined [enabled by default]
   #define CONFIG_CMD_RUN  /* run command in env variable */
    ^
    In file included from ././include/linux/kconfig.h:4:0,
                     from <command-line>:0:
		     include/generated/autoconf.h:35:0: note: this is
  the location of the previous definition
   #define CONFIG_CMD_RUN 1
    ^
      HOSTCC  tools/mkenvimage.o
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html