[U-Boot] [u-boot-release] [PATCH] driver: misc: debug server: Update Error message

[Sharma Bhupesh]

Hi Prabhakar,

Thanks for the patch.

A few nitpicks. Otherwise:

Reviewed-by: Bhupesh Sharma <bhupesh.sharma at freescale.com>


> From: u-boot-release-bounces at linux.freescale.net [mailto:u-boot-release-
> bounces at linux.freescale.net] On Behalf Of Prabhakar Kushwaha
> Sent: Sunday, August 09, 2015 8:53 AM
> 
> Apped "debug server image" in error message to make more informative.

  ^^^^
Typo? I guess you meant Append here.

> 
> Signed-off-by: Prabhakar Kushwaha <prabhakar at freescale.com>
> ---
>  drivers/misc/fsl_debug_server.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/misc/fsl_debug_server.c
> b/drivers/misc/fsl_debug_server.c index 44cd9b9..318626d 100644
> --- a/drivers/misc/fsl_debug_server.c
> +++ b/drivers/misc/fsl_debug_server.c
> @@ -60,29 +60,29 @@ int debug_server_parse_firmware_fit_image(const void
> **raw_image_addr,
>  	/* Check if Image is in FIT format */
>  	format = genimg_get_format(fit_hdr);
>  	if (format != IMAGE_FORMAT_FIT) {
> -		printf("Error! Not a FIT image\n");
> +		printf("Debug Server Image: Not a FIT image\n");

Can we change it to something like this instead (as similarly on the changes that follow):

Debug Server FW: Not a FIT image

>  		goto out_error;
>  	}
> 
>  	if (!fit_check_format(fit_hdr)) {
> -		printf("Error! Bad FIT image format\n");
> +		printf("Debug Server Image: Bad FIT image format\n");
>  		goto out_error;
>  	}
> 
>  	node_offset = fit_image_get_node(fit_hdr, uname);
>  	if (node_offset < 0) {
> -		printf("Error! Can not find %s subimage\n", uname);
> +		printf("Debug Server Image:Can not find %s subimage\n",
> uname);
>  		goto out_error;
>  	}
> 
>  	/* Verify Debug Server firmware image */
>  	if (!fit_image_verify(fit_hdr, node_offset)) {
> -		printf("Error! Bad Debug Server firmware hash");
> +		printf("Debug Server Image: Bad Debug Server firmware hash");
>  		goto out_error;
>  	}
> 
>  	if (fit_get_desc(fit_hdr, node_offset, &desc) < 0) {
> -		printf("Error! Failed to get Debug Server fw description");
> +		printf("Debug Server Image: Failed to get FW description");
>  		goto out_error;
>  	}
> 
> --
> 1.9.1
>