[U-Boot] [PATCH 1/3] drivers: Introduce a simplified remoteproc framework

[Simon Glass]

Hi Nishanth,

On 25 August 2015 at 09:44, Nishanth Menon <nm at ti.com> wrote:
> On 08/25/2015 12:04 AM, Simon Glass wrote:
> [...]
>>> index 000000000000..e8fdb124e251
>>> --- /dev/null
>>> +++ b/common/cmd_remoteproc.c
[snip]
>>
>>> +       .id = UCLASS_RPROC,
>>> +       .name = "remoteproc",
>>> +       .flags = DM_UC_FLAG_SEQ_ALIAS,
>>> +       .pre_probe = rproc_pre_probe,
>>> +       .post_probe = rproc_post_probe,
>>> +       .per_device_platdata_auto_alloc_size =
>>> +               sizeof(struct dm_rproc_uclass_pdata),
>>> +       /* *INDENT-ON* */
>>> +};
>>> +
>>> +/* exported functions */
>>
>> But this is not exported is it?
>
> Agreed. will rephrase. how about "remoteproc subsystem access functions" ?

Sure

>>> +#include <dm/platdata.h>       /* For platform data support - non dt world */
>>
>> Does this need to be supported for a new uclass?
>
> we do have platforms that are not using DT yet... they will need to pass
> platform data.

Is this a good opportunity to convert them?

>
> Thanks for the detailed review. will drop in an updated rev soon.

My comments are minor. It's a very tidy patch set already.

Regards,
Simon