[U-Boot] [PATCH] x86: Clean up SPI flash drivers in defconfig

Simon Glass sjg at chromium.org
Tue Dec 1 17:32:40 CET 2015


Hi Bin,

On 28 November 2015 at 05:45, Bin Meng <bmeng.cn at gmail.com> wrote:
> Every board has one dedicated type of SPI flash, hence it is
> unnecessary to include multiple SPI flash drivers.
>
> For QEMU and coreboot (default build of coreboot is also QEMU),
> SPI flash is not supported. Remove those SPI flash drivers.
>
> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> ---
>
>  configs/bayleybay_defconfig         | 2 --
>  configs/chromebook_link_defconfig   | 2 --
>  configs/chromebox_panther_defconfig | 2 --
>  configs/coreboot-x86_defconfig      | 4 ----
>  configs/crownbay_defconfig          | 3 ---
>  configs/galileo_defconfig           | 2 --
>  configs/minnowmax_defconfig         | 3 ---
>  configs/qemu-x86_defconfig          | 4 ----
>  8 files changed, 22 deletions(-)

What is the benefit of this? I see it removes a few lines in a data
table. Does it matter?

For all of these platforms we can use the dediprog em100 which I
typically set to use winbond as the manufacturer, regardless of which
chip is actually on the board.

For U-Boot on coreboot, why is SPI flash not supported? It certainly
works with link.

Regards,
Simon


More information about the U-Boot mailing list