[U-Boot] [PATCH] mkimage: Fix generating multi and script images again

Philippe De Swert philippedeswert at gmail.com
Mon Dec 7 21:52:58 CET 2015


Hi,

On 07/12/15 21:06, Tom Rini wrote:
> On Mon, Dec 07, 2015 at 06:01:54PM +0100, Marek Vasut wrote:
>
>> Seems 6ae6e160 broke creating multi and script type images and even
>> building of mkimage itself. There are two problems with that patch.
>>
>> First is that expression (!(x == 0) || !(x == 1)) is always true for
>> unsigned int x. The expression must use AND (&&) not OR (||) to be
>> correct.
>>
>> After rewording the commit message a bit (and talking with Marek on IRC
>> about my reword), applied to u-boot/master, thanks!
>>

Great! Apologies for the breakage,

Philippe


More information about the U-Boot mailing list