[U-Boot] [PATCH 1/5] Make RBTREE selectable by Kconfig

Joe Hershberger joe.hershberger at gmail.com
Tue Dec 15 23:54:45 CET 2015


Hi Lars,

On Tue, Dec 15, 2015 at 8:44 AM, Lars Poeschel <poeschel at lemonage.de> wrote:
> Am Dienstag, 18. August 2015, 14:32:13 schrieb Joe Hershberger:
>> On Tue, Aug 18, 2015 at 2:27 PM, Tom Rini <trini at konsulko.com> wrote:
>> > On Tue, Aug 18, 2015 at 01:47:20PM -0500, Joe Hershberger wrote:
>> >> Hi Lars,
>> >>
>> >> On Tue, Aug 11, 2015 at 2:29 PM, Joe Hershberger
>> >>
>> >> <joe.hershberger at gmail.com> wrote:
>> >> > Hi Lars,
>> >> >
>> >> > On Tue, Jul 28, 2015 at 11:01 AM, Joe Hershberger
>> >> >
>> >> > <joe.hershberger at gmail.com> wrote:
>> >> >> Hi Lars,
>> >> >>
>> >> >> On Tue, Jul 28, 2015 at 3:25 AM, Lars Poeschel <poeschel at lemonage.de>
> wrote:
>> >> >>> Hi Joe,
>> >> >>>
>> >> >>> On Wed, Jun 10, 2015 at 11:03:59AM -0500, Joe Hershberger wrote:
>> >> >>>> >> I beat you to it:
>> >> >>>> >> http://lists.denx.de/pipermail/u-boot/2015-May/214261.html>> >>>>
>>
>> >> >>>> > Well, ... ok. You won ;-) Your patchset is by far more
>> >> >>>> > comprehensive than
>> >> >>>> > mine.
>> >> >>>> > If I see this right in the archives, you did not receive any
>> >> >>>> > comments
>> >> >>>> > since nearly a month.
>> >> >>>>
>> >> >>>> That is true. I really would like a little feedback on it... or
>> >> >>>> maybe
>> >> >>>> I can just drop the controversial one and only include these
>> >> >>>> things...
>> >> >>>> they seem to be mostly straightforward.
>> >> >>>>
>> >> >>>> > This was RFC will you resend this as a "real" PATCH ?
>> >> >>>>
>> >> >>>> Yes.
>> >> >>>>
>> >> >>>> > Could you then include two of the dependencies from my patches:
>> >> >>>> > I think CMD_UBI has to depend on MTD_PARTITIONS and obivously
>> >> >>>> > CMD_UBIFS
>> >>
>> >> I noticed when adding MTD_PARTITIONS that MTD_DEVICE is not moved over
>> >> yet. Do you know what the dependency relationship is there? If not
>> >> I'll dig into it a bit.
>> >>
>> >> >>>> > has to depend on CMD_UBI.
>> >> >>>>
>> >> >>>> Will do.
>> >> >>>
>> >> >>> I saw no action from you on this one. Can I help out - at least for
>> >> >>> the
>> >> >>> decompression / ubi / ubifs part ?
>> >> >>
>> >> >> Sorry about that... the end of last release got a little crazy.
>> >> >>
>> >> >>> I think the setexpr / env location parts from your patchset can then
>> >> >>> go
>> >> >>> in as seperate patches.
>> >> >>
>> >> >> I agree. I'll split them apart and send these out.
>> >> >
>> >> > I haven't forgotten about this... I plan to get this sent out this
>> >> > week.
>> >>
>> >> I had this ready to go, but conflicts with
>> >> https://patchwork.ozlabs.org/patch/508134/, so I'm gonna have to
>> >> regenerate the moves after that goes in.
>> >
>> > Note that since it's part of the E1000 series I gave it to you in
>> > patchwork :)
>>
>> Sure, I expect to take it in once all feedback is addressed on that series.
>> :)
>
> Joe,
> a gentle ping on this.
> I don't see RBTREE, MTD_PARTIONS and UBIFS in Kconfig yet.

Argh! I forgot that I had this sitting in a branch that still had a
few targets not building cleanly. This moving configs stuff is a pain
when so many boards use them and in odd / slightly different ways.

Now all the work has to be regenerated and reanalyzed for build
failures. Maybe I'll just start with one dependency... get that in,
then focus on the next, etc. There are so many boards that conflict
readily if you have to spend any amount of time resolving issues.

Sorry for the delay.
-Joe


More information about the U-Boot mailing list