[U-Boot] [PATCH v2] usb: eth: asix88179: add ability to modify MAC address

René Griessl rgriessl at cit-ec.uni-bielefeld.de
Mon Jan 12 18:07:27 CET 2015


Am 12.01.2015 um 17:54 schrieb Marek Vasut:
> On Monday, January 12, 2015 at 05:51:16 PM, Rene Griessl wrote:
>> This patch enables U-Boot to modify the MAC address of the AX88179.
>> Tested on RECS5250 (similar to Arndale5250)
>>
>> Signed-off-by: Rene Griessl <rgriessl at cit-ec.uni-bielefeld.de>
>> ---
>>
>> Changes for v2:
>> 	- removed memcpy
> Hi!
>
> what was the reason for the memcpy() in the first place please ?
I copied the function from the asix.c driver. There it is needed for the 
cache aligned buffer.
But in this case the alignment is already implemented in the write 
function. So you were right, it is not needed here!
> Otherwise,
>
> Reviewed-by: Marek Vasut <marex at denx.de>
>
> Best regards,
> Marek Vasut

-- 

--------------------------------------------------------

Dipl.-Ing. René Griessl
Universität Bielefeld
AG Kognitronik & Sensorik
Exzellenzcluster Cognitive Interaction Technology (CITEC)
Inspiration 1 (Zehlendorfer Damm 199)
33615 Bielefeld

Telefon : +49 521-106-67362
Fax     : +49 521-106-12348
eMail   : rgriessl at cit-ec.uni-bielefeld.de
Internet: http://www.ks.cit-ec.uni-bielefeld.de/



More information about the U-Boot mailing list