[U-Boot] [PATCH] lcd: fix console address is not initialized

Bo Shen voice.shen at atmel.com
Wed Jan 28 02:08:03 CET 2015


Hi Nikita Kiryanov,

On 01/27/2015 10:45 PM, Nikita Kiryanov wrote:
>> Can we use the following patch to fix this issue?
>> --->8---
>> diff --git a/common/lcd.c b/common/lcd.c
>> index cc34b8a..1195a54 100644
>> --- a/common/lcd.c
>> +++ b/common/lcd.c
>> @@ -268,6 +268,7 @@ void lcd_clear(void)
>>          console_rows = panel_info.vl_row / VIDEO_FONT_HEIGHT;
>>   #endif
>>          console_cols = panel_info.vl_col / VIDEO_FONT_WIDTH;
>> +       lcd_init_console(lcd_base, console_rows, console_cols);
>>          lcd_init_console(lcd_logo(), console_rows, console_cols);
>>          lcd_sync();
>>   }
>> ---8<---
>>
>> It first initializes the lcd console with LCD base, if the splash
>> screen is used, new address is updated.
>
>
> I think this is the best approach. I am very close to posting the next

Thanks for review. I think send this fix patch first, and then you can 
based on this patch for your next step, or else, we can not know how 
long it will break most Atmel SoC related boards on master branch. So, I 
will send this patch and try to get it applied as soon as possible.

Thanks again.

> step in my refactor of lcd.c, and I can
> incorporate it in the series. I will greatly appreciate your help in
> testing this series, since it involves Atmel
> related changes.
>
>>
>> I need this kind of fix to be applied as soon as possible, or else,
>> most Atmel related board are broken on u-boot master branch.
>>
>> Best Regards,
>> Bo Shen
>
> --
> Regards,
> Nikita Kiryanov

Best Regards,
Bo Shen


More information about the U-Boot mailing list