[U-Boot] [PATCH 1/3] sunxi: musb: Improve output during probing

Hans de Goede hdegoede at redhat.com
Tue Jun 23 12:02:49 CEST 2015


Hi,

On 22-06-15 18:11, Ian Campbell wrote:
> On Mon, 2015-06-22 at 17:39 +0200, Hans de Goede wrote:
>> How about the following:
>>
>>
>> Subject: [PATCH 1/3] sunxi: musb: Improve output during probing
>>
>> When we return an error the usb core will log a message, so in this case
>> do not print anything.
>>
>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>
> Much better, especially given the below.
>
> Acked-by: Ian Campbell <ian.campbell at citrix.com>

Thanks.

>
>>
>> --- a/drivers/usb/musb-new/sunxi.c
>> +++ b/drivers/usb/musb-new/sunxi.c
>> @@ -301,21 +301,22 @@ int musb_usb_probe(struct udevice *dev)
>>    {
>>           struct musb_host_data *host = dev_get_priv(dev);
>>           struct usb_bus_priv *priv = dev_get_uclass_priv(dev);
>> +       int ret;
>
> Wrong sort of w/space I suspect.

Nope, this comes from me copy and pasting the diff output
from a xterm, I just double checked and the whitespace is as
it should be in my tree :)

Regards,

Hans


More information about the U-Boot mailing list