[U-Boot] [PATCH v3] sf_probe: Add lock ops for SST SPI NOR flash

Fabio Estevam festevam at gmail.com
Tue Nov 17 20:09:47 CET 2015


On Tue, Nov 17, 2015 at 4:59 PM, Jagan Teki <jteki at openedev.com> wrote:
> On 18 November 2015 at 00:20, Fabio Estevam <festevam at gmail.com> wrote:
>> From: Fabio Estevam <fabio.estevam at freescale.com>
>>
>> SST SPI NOR flash has the same locking programming bits as ST Micro.
>>
>> Add support for it.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
>> Reviewed-by: Jagan Teki <jteki at openedev.com>
>
> Minor edit on commit message.

Not sure I understood your change. It seems to me that you changed
"Add support for it" to "- added support for it."

Why did you do this?

In U-boot and kernel we should use imperative mood in the commit log.

Please check http://www.denx.de/wiki/U-Boot/Patches and also
Documentation/SubmittingPatches.


More information about the U-Boot mailing list