[U-Boot] [linux-sunxi] [PATCH 2/6] fastboot: Implement OEM format only when we have MMC support

Hans de Goede hdegoede at redhat.com
Fri Sep 18 16:53:51 CEST 2015


Hi,

On 09/18/2015 08:06 AM, Maxime Ripard wrote:
> The current fastboot support assumes that CONFIG_FASTBOOT_FLASH implies
> that we have an MMC in our system, which might not be the case if we have
> some other storage device.
>
> Change the configuration option protecting that call to
> FASTBOOT_FLASH_MMC_DEV, that makes much more sense.
>
> Signed-off-by: Maxime Ripard <maxime.ripard at free-electrons.com>

Note I'm not going to take this one upstream through the sunxi tree,
other then that it looks fine to me.

Regards,

Hans


> ---
>   drivers/usb/gadget/f_fastboot.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/f_fastboot.c b/drivers/usb/gadget/f_fastboot.c
> index ca01a018b5d1..ece48e668c96 100644
> --- a/drivers/usb/gadget/f_fastboot.c
> +++ b/drivers/usb/gadget/f_fastboot.c
> @@ -554,7 +554,7 @@ static void cb_flash(struct usb_ep *ep, struct usb_request *req)
>   static void cb_oem(struct usb_ep *ep, struct usb_request *req)
>   {
>   	char *cmd = req->buf;
> -#ifdef CONFIG_FASTBOOT_FLASH
> +#ifdef CONFIG_FASTBOOT_FLASH_MMC_DEV
>   	if (strncmp("format", cmd + 4, 6) == 0) {
>   		char cmdbuf[32];
>                   sprintf(cmdbuf, "gpt write mmc %x $partitions",
>


More information about the U-Boot mailing list