[U-Boot] [PATCH v5] nios2: convert altera_jtag_uart to driver model

[Simon Glass]

Hi,

On 19 September 2015 at 09:46, Simon Glass <sjg at chromium.org> wrote:
> Hi Thomas,
>
> On 18 September 2015 at 00:23, Thomas Chou <thomas at wytron.com.tw> wrote:
>>
>> Convert altera_jtag_uart to driver model.
>>
>> Signed-off-by: Thomas Chou <thomas at wytron.com.tw>
>> ---
>>
>> v2
>>   add ioremap.
>>   make the change to dts compatible with linux.
>>
>> v3
>>   use fdt address translation patch from Stefan Roese.
>>   fix watchdog and loop as Marek suggested.
>>
>> v4
>>   add clear AC flag to probe().
>>   remove polling loops and watchdog reset because they are
>>     done in the serial-uclass.c.
>>
>> v5
>>   fix coding style as Marek suggested to altera_uart.
>>
>>  arch/nios2/dts/3c120_devboard.dts |   5 ++
>>  configs/nios2-generic_defconfig   |   3 +
>>  drivers/serial/Kconfig            |  13 ++++
>>  drivers/serial/altera_jtag_uart.c | 145 ++++++++++++++++++++++----------------
>>  include/configs/nios2-generic.h   |   3 -
>>  5 files changed, 106 insertions(+), 63 deletions(-)
>
> This looks right to me but I have some comments below.
>
> Reviewed-by: Simon Glass <sjg at chromium.org>

Actually I have one more comment - consider implementing
CONFIG_DEBUG_UART in this driver. That way you can have UART output
before driver model is ready.

Regards,
Simon