[U-Boot] [PATCH 1/1] Kconfig: net: give PHYLIB to designware driver

[Bin Meng]

Hi Olliver,

On Mon, Sep 21, 2015 at 3:18 PM, Olliver Schinagl
<o.schinagl at ultimaker.com> wrote:
> Hey Bin,
>
>
> On 21-09-15 03:50, Bin Meng wrote:
>>
>> Hi Olliver,
>>
>> On Fri, Sep 18, 2015 at 11:29 PM, Olliver Schinagl
>> <oliver+list at schinagl.nl> wrote:
>>>
>>> From: Olliver Schinagl <o.schinagl at ultimaker.com>
>>>
>>> The designware driver has a build guard which makes it to only work when
>>> using the PHYLIB. With b68fe152272 the PHYLIB was added to the net
>>> Kconfig but not selected by all hardware depending on it.
>>>
>>> This patch enables PHYLIB for the Designware MAC
>>>
>>> Signed-off-by: Olliver Schinagl <o.schinagl at ultimaker.com>
>>> ---
>>>   drivers/net/Kconfig | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
>>> index bbec6a6..51b1668 100644
>>> --- a/drivers/net/Kconfig
>>> +++ b/drivers/net/Kconfig
>>> @@ -79,10 +79,10 @@ config ETH_SANDBOX_RAW
>>>
>>>   config ETH_DESIGNWARE
>>>          bool "Synopsys Designware Ethernet MAC"
>>> +       select PHYLIB
>>>          help
>>>            This MAC is present in SoCs from various vendors. It supports
>>> -         100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to
>>> -         provide the PHY (physical media interface).
>>> +         100Mbit and 1 Gbit operation.
>>>
>>>   config PCH_GBE
>>>          bool "Intel Platform Controller Hub EG20T GMAC driver"
>>> --
>>
>> This is not enough. You need update all borads' config.h files to
>> remove CONFIG_PHYLIB, otherwise it causes redefinition warnings.
>
> I was being conservative here,
>
> Is it enough to only do the boards that are featured using Kconfig?

I think all boards have been converted to Kconfig, no?

>>
>>
>> Regards,
>> Bin
>
>
> --
> Met vriendelijke groeten, Kind regards, 与亲切的问候

Ah, you know Chinese :-)

>
> Olliver Schinagl
> Research & Development
> Ultimaker B.V.
>

Regards,
Bin