[U-Boot] Antwort: [PATCH] drivers/video/am335x-fb: Fix bits for LCD_PALMODE_RAWDATA definition

Hannes Schmelzer Hannes.Schmelzer at br-automation.com
Tue Apr 26 07:45:24 CEST 2016


> 
> According to the TRM you have to set bits [21:20] to 0b10 for RAW mode, 
so
> (0x10 << 20) is obviously wrong here.
> 
> Signed-off-by: Martin Pietryka <martin.pietryka at chello.at>
> ---
>  drivers/video/am335x-fb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/am335x-fb.c b/drivers/video/am335x-fb.c
> index e23d172..0ec843f 100644
> --- a/drivers/video/am335x-fb.c
> +++ b/drivers/video/am335x-fb.c
> @@ -55,7 +55,7 @@
>  /* LCD Raster Ctrl Register */
>  #define LCD_TFT_24BPP_MODE         (1 << 25)
>  #define LCD_TFT_24BPP_UNPACK         (1 << 26)
> -#define LCD_PALMODE_RAWDATA         (0x10 << 20)
> +#define LCD_PALMODE_RAWDATA         (0x02 << 20)
>  #define LCD_TFT_MODE            (0x01 << 7)
>  #define LCD_RASTER_ENABLE         (0x01 << 0)
> 
> -- 
> 2.8.0

Reviewed-by: Hannes Schmelzer <hannes.schmelzer at br-automation.com>



More information about the U-Boot mailing list