[U-Boot] [PATCH] fs: ext4: fix symlink read function

Stephen Warren swarren at wwwdotorg.org
Wed Apr 27 19:34:31 CEST 2016


On 04/27/2016 10:40 AM, Stefan Roese wrote:
> From: Ronald Zachariah <rozachar at cisco.com>
>
> The function ext4fs_read_symlink was unable to handle a symlink
> which had target name of exactly 60 characters.

Reviewed-by: Stephen Warren <swarren at nvidia.com>

This seems to match how the Linux kernel encodes symlinks.

> -	if (__le32_to_cpu(diro->inode.size) <= 60) {
> +	if (__le32_to_cpu(diro->inode.size) < 60) {

It'd be nice if "60" was replaced with sizeof(diro->inode.b.symlink), 
but that's probably a topic for a different patch.


More information about the U-Boot mailing list