[U-Boot] [PATCH v1 10/16] drivers: Add SPMI bus uclass

Mateusz Kulikowski mateusz.kulikowski at gmail.com
Mon Jan 11 22:41:49 CET 2016


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi Simon ,

On 11.01.2016 17:57, Simon Glass wrote:
[...]
>> @@ -0,0 +1,10 @@
>> +menu "SPMI support"
>> +
>> +config DM_SPMI
> 
> Can we just use SPMI, or is that is use? We want to remove all the DM_
> options when everything is converted to driver model. So if you are
> adding a new class you should be able to avoid the DM_ prefix.

Sure, I thought it's mandatory :)

[..]
>> +
>> +#include <common.h>
>> +#include <dm.h>
>> +#include <dm/root.h>
>> +#include <errno.h>
>> +#include <spmi/spmi.h>
>> +#include <linux/ctype.h>
> 
> http://www.denx.de/wiki/U-Boot/CodingStyle
> 
> common.h
> dm.h
> errno.h
> dm/...
> spmi/...
> linux/...

Oops, this slipped - my bad

Regards,
Mateusz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJWlCGaAAoJELvtohmVtQzB8HsH/2C5C6qWhUpBlXiyhXLBa7TG
6KWy+NwrGdadwi1IT/UiBbryM7O6YT+H/Ey7MIfC0VNyhPnSiMimCYH7RQoNtoYT
lA5QUb1FAAvVbyypD9t0CRl32uORbG/2WocDdPbAjyTJp3/GldwZ0ZjeQo2uOedv
zUmwEmMiylff7m2wjD4EhEJayyTF/8oVCaqH4OtlxwupIHMgekPNUBjtW5VfjPMP
oldrwD2k2nbAj7Y91nxKPQiMgql4eOdXQCnwkW4ovz6wB1jb9/b8d42W75rhFoDu
2FRcP6NWR9XurMQIjtSz7O587UrGWrKm4ts7MjjhMMt4aPjDVNd+9CE+R8mEu3A=
=gUUy
-----END PGP SIGNATURE-----


More information about the U-Boot mailing list