[U-Boot] [PATCH 2/4] atmel_nand: add '\n' in the end of error message for better display

Andreas Bießmann andreas.devel at googlemail.com
Sun Jan 24 22:31:23 CET 2016


Hi Josh,

On 24.11.15 09:26, Josh Wu wrote:
> Also align the open parenthesis.
> 
> Signed-off-by: Josh Wu <josh.wu at atmel.com>
> ---
> 
>  drivers/mtd/nand/atmel_nand.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index e179f74..5226acf 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -821,8 +821,8 @@ static int atmel_pmecc_nand_init_params(struct nand_chip *nand,
>  	 * from ONFI.
>  	 */
>  	if (pmecc_choose_ecc(host, nand, &cap, &sector_size)) {
> -		dev_err(host->dev, "The NAND flash's ECC requirement(ecc_bits: %d, sector_size: %d) are not support!",
> -				cap, sector_size);
> +		dev_err(host->dev, "The NAND flash's ECC requirement(ecc_bits: %d, sector_size: %d) are not support!\n",
> +			cap, sector_size);

Could you please rephrase this?

NAND flash's ECC requirement (ecc_bits: %d, sector_size: %d) is not
supported!

or since dev_err() should print pmecc in any case:

Required ECC %d bits in %d bytes not supported!

Andreas

>  		return -EINVAL;
>  	}
>  
> 


More information about the U-Boot mailing list