[U-Boot] [PATCH 1/1] configs/wandboard.h: fix dtb file name for findfdt.

[Wolfgang Denk]

Dear Adam Duskett,

In message <BLU436-SMTP46BCB8C63151CD3166FBD1B9360 at phx.gbl> you wrote:
> With the release of kernel 4.1.15 for the imx6 line of processors,
> wandboard now uses imx6q-wandboard-revc1.dtb and imx6dl-wandboard-revc1.dtb.
> This patch fixes the naming convention to work with kernel 4.1.15
> 
> Signed-off-by: Adam Duskett <adamduskett at outlook.com>
> ---
>  include/configs/wandboard.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/configs/wandboard.h b/include/configs/wandboard.h
> index 99f5c0c..d41b600 100644
> --- a/include/configs/wandboard.h
> +++ b/include/configs/wandboard.h
> @@ -135,9 +135,9 @@
>  		"setenv bootargs ${bootargs} ${fbmem}\0" \
>  	"findfdt="\
>  		"if test $board_name = C1 && test $board_rev = MX6Q ; then " \
> -			"setenv fdtfile imx6q-wandboard.dtb; fi; " \
> +			"setenv fdtfile imx6q-wandboard-revc1.dtb; fi; " \
>  		"if test $board_name = C1 && test $board_rev = MX6DL ; then " \
> -			"setenv fdtfile imx6dl-wandboard.dtb; fi; " \
> +			"setenv fdtfile imx6dl-wandboard-revc1.dtb; fi; " \
>  		"if test $board_name = B1 && test $board_rev = MX6Q ; then " \
>  			"setenv fdtfile imx6q-wandboard-revb1.dtb; fi; " \
>  		"if test $board_name = B1 && test $board_rev = MX6DL ; then " \

Instead of adding to an ever growing list of names, would it not make
sense to solve this programmatically, like by concatenating "i" +
tolower($board_rev) + "-wandboard-rev" + tolower($board_name) + ".dtb"?

I guess this would also result in shorter / faster script code?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Boykottiert Microsoft - Kauft Eure Fenster bei OBI!