[U-Boot] [RFC PATCH] i2c: i2c-uclass-compat: avoid any BSS usage

Vignesh R vigneshr at ti.com
Thu Jul 28 07:54:33 CEST 2016



On Tuesday 26 July 2016 11:53 AM, Heiko Schocher wrote:
> Hello Vignesh,
> 
> Am 25.07.2016 um 12:56 schrieb Vignesh R:
>> As I2C can be used before DRAM initialization for reading EEPROM,
>> avoid using static variables stored in BSS, since BSS is in DRAM, which
>> may not have been initialised yet. Explicitly mark "static global"
>> variables as belonging to the .data section.
>>
>> Signed-off-by: Vignesh R <vigneshr at ti.com>
>> ---
>>   drivers/i2c/i2c-uclass-compat.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Acked-by: Heiko Schocher<hs at denx.de>
> 

Thanks! Would you be picking up this patch?

>>
>> diff --git a/drivers/i2c/i2c-uclass-compat.c
>> b/drivers/i2c/i2c-uclass-compat.c
>> index 5606d1f807f6..de78db6a887f 100644
>> --- a/drivers/i2c/i2c-uclass-compat.c
>> +++ b/drivers/i2c/i2c-uclass-compat.c
>> @@ -9,7 +9,7 @@
>>   #include <errno.h>
>>   #include <i2c.h>
>>
>> -static int cur_busnum;
>> +static int cur_busnum __attribute__((section(".data")));
>>
>>   static int i2c_compat_get_device(uint chip_addr, int alen,
>>                    struct udevice **devp)
>>
> 

-- 
Regards
Vignesh


More information about the U-Boot mailing list